possatti / pokemonsay

"pokemonsay" is like "cowsay" but for pokémon.
MIT License
506 stars 55 forks source link

Scrapper has trouble with special characters when using National Dex + National cows #6

Open marcosins opened 7 years ago

marcosins commented 7 years ago

After some trouble (mostly imagemagick) i managed to create cows for every pokemon in the national dex*.

The scrapper script has troubles when the alt attribute has special characters in it ("Tapu Koko", "Mr. Mime", "Type:Null"). I modified it a little to use https and read the src attribute that uses // instead of http:// or https://

I hope this is helpful :+1:

scrap_data.sh.zip NationalCows.zip

*Lycanroc Midnight form isn't listed in Bulbapedia's National Dex and it's too late to care now

marcosins commented 7 years ago

Sorry for the close/reopen, i'm too tired. Here's a screenshot in Terminator with multiple generation pokemon. pokemonsaynationaldex

nosrednawall commented 6 years ago

thanks, you are the best.