Review: AI Gen Examples for rec.fromarrays - Githubissues

possee-org / genai-numpy

MIT License

4 stars 6 forks source link

Review: AI Gen Examples for rec.fromarrays #115

Closed otieno-juma closed 3 months ago

otieno-juma commented 3 months ago

Link to your fork:

https://github.com/numpy/numpy/compare/main...otieno-juma:numpy:ai-examples-ma-rec_fromarrays

Checks

spin build && python -m pip install . && spin docs && python tools/refguide_check.py --doctests && spin lint

[ ] All tests have passed
[ ] A visual inspection of the generated docs is correct

Acceptance Criteria:

Close when the following are complete, in order:

[ ] Reviewed by @bmwoodruff
[ ] Any suggestions to fork have been merged.
[ ] Reviewed by Numpy Mainter:

When all tasks are complete:

[ ] Submitted as PR to NumPy.

fromarrays

bmwoodruff commented 3 months ago

Without running any tests, this looks fine. However, it's not signficantly different from what's already in the examples to justify adding it to the codebase, in my opinion. I'm going to close this one.