possee-org / genai-numpy

MIT License
4 stars 6 forks source link

Review: AI Gen Examples for ma.put #80

Open otieno-juma opened 1 week ago

otieno-juma commented 1 week ago

Link to your fork:

(https://github.com/numpy/numpy/compare/main...otieno-juma:numpy:ai-examples-ma-put)

Checks

spin build && python -m pip install . && spin docs && python tools/refguide_check.py --doctests

Acceptance Criteria:

Close when the following are complete, in order:

When all tasks are complete:

put fuction pic

bmwoodruff commented 1 week ago

@otieno-juma , It looks like AI decided to add a : to the end of examples. You'll need to remove the colon, and then extra - below it. The examples checkout fine.

I'm glad you submitted this one, as it is something we'll have to check as we process the examples.

Have you tried using https://github.com/possee-org/genai-numpy/blob/main/tools/review/example-checker.ipynb to generate correct output?

When you get the change made, ping me here.

otieno-juma commented 1 week ago

I have made all necessary changes and combined my commits into one.

bmwoodruff commented 1 week ago

Looks good to me. I'll put this on a list for Chuck to look at.

bmwoodruff commented 1 week ago

@charris, this is ready for your review.