possee-org / genai-numpy

MIT License
4 stars 6 forks source link

Review: AI Gen Examples for ma.left_shift function #82

Open otieno-juma opened 1 week ago

otieno-juma commented 1 week ago

Link to your fork:

(https://github.com/numpy/numpy/compare/main...otieno-juma:numpy:ai-examples-ma-left_shift)

Checks

spin build && python -m pip install . && spin docs && python tools/refguide_check.py --doctests

Acceptance Criteria:

Close when the following are complete, in order:

When all tasks are complete:

left_shift pic

bmwoodruff commented 1 week ago

There are too many similar examples. Your first two don't have the proper spacing either (I think you forgot to space things over). My guess is the 3rd and 5th are enough. You can decide if you want to keep the 1st or 4th, but I'd keep the 4th before keeping the 2nd.

Have you tried using https://github.com/possee-org/genai-numpy/blob/main/tools/review/example-checker.ipynb yet? The spacing problem is automated (this is what I worked on at the end of last week). Clone your fork of genai-numpy to Nebari, and then try using it. The relevant function is clean_and_process_text in reviewtools.py (which I called rt in the ipynb notebook).

otieno-juma commented 1 week ago

I plan on using that tool today, the three functions were backlogs from previous examples that I generated

otieno-juma commented 1 week ago

I have made all the necessary changes to the examples and squashed all the commits into one commit message.

bmwoodruff commented 1 week ago

@charris, this is ready for your review.