search

post-kerbin-mining-corporation / CryoTanks

Adds cryogenic fuel storage options and limited fuel switching to Kerbal Space Program
15 stars 30 forks source link

ProceduralParts consistent to stock tanks in mass and methane support. #120

Closed tomasbrod closed 3 years ago

tomasbrod commented 3 years ago

The LFO is left untouched, but appears to be consistent to stock tanks. MethaOxi was added. MethaOxi and HydroOxi were made consistent with the insulated cryo tanks in both dry mass and cost.

tomasbrod commented 3 years ago

Issue https://github.com/hemeac/kiwiTechTree/issues/94 is related.

tomasbrod commented 3 years ago

Appears that SMURFF breaks a bit more with this, than it was broken without on Procparts.

ChrisAdderley commented 3 years ago

Is that an issue, or can I merge this?

tomasbrod commented 3 years ago

I was struggling to make this work with SMURFF, but only way I managed was to rename the TANK_TYPE_OPTION and rewrite the smurff-like patch. That will probably break crafts, but considering the mass ratio was broken before, probably none was using it. On the upside, the label now fits the UI. Maybe add another patch to rename it back?

ChrisAdderley commented 3 years ago

I personally don't really know what to do there. I'm going to say it's your call :). Let me know when it's ready and i'll merge it in and it'll be in next version.

tomasbrod commented 3 years ago

With this patch, it is as good as it gets.

ChrisAdderley commented 3 years ago

Thanks!