search

post-kerbin-mining-corporation / CryoTanks

Adds cryogenic fuel storage options and limited fuel switching to Kerbal Space Program
15 stars 30 forks source link

Tanks boiloff even when electricity need is completely satiated, only at over x1000 #126

Closed rp1-lox closed 1 month ago

rp1-lox commented 2 years ago

During a session, I noticed that tanks would boil off at over 1000x warp. At 1000x , they would work just fine. Any faster, however, and the tanks would begin to boil off. I switched on infinite electricity, and the game demonstrated the same problem. KSP.log attached KSP.log :

ChrisAdderley commented 2 years ago

Please provide more information, such as a reproducible test case (steps to reproduce the issue with a minimum mod list) and a mod list (specifically with versions of CryoTanks and Dynamic Battery Storage).

endrjux commented 1 year ago

Hello,

I think I observe somewhat similar behavior - in max warp, electricity is being depleted even though it should not be. While this is reported in this repo, I think this is rather Dynamic Battery Storage issue.

I removed all irrelevant mods (ie. I left only cryo mods and their dependencies) and started a new sandbox game. I built a test rocket, with LH2 tanks (cooling on, both stock tank and cryo tank to see if the behave differently), probe core, batteries, solar panels and some lights. I put that vessel in 86 km orbit using debug menu.

obraz

2k EC storage should last for about 50 minutes and dark time is around 11 minutes, so the vehicle shouldn't ever run out of power and LH2 shouldn't boil off. Everything works as expected up to max warp speed. I wanted to test if this is something specific to cryo tanks, so I disabled cooling and only kept lights on. The same thing happened - in max warp EC goes to 0 and lights turn off. Later, when lights are off and the only drain comes from the probe core (and reaction wheel?), everything seems to be fine (though it's somewhat difficult to tell if the problem is still there, I guess it is, just harder to notice).

Log: cryo_power_issue.log (I enabled debug in Dynamic Battery Storage) Craft: Cryo EC test.craft.txt (github doesn't like .craft extension) Cryo Tanks 1.6.5, Dynamic Battery Storage 2.2.5.0

I also tested a minimal rocket - tanks, probe, batteries, panels. It behaves the same. Dynamic Battery Storage doesn't seem to take reaction wheel into consideration, but EC goes to 0 and LH2 boils off even without it, so I think this is unrelated. I also checked if it matters if cooling is on/off on stock or cryo tank and it doesn't. In the end I think this is not related to any part - it's most likely Dynamic Battery Storage issue. (Actually it's a KSP issue because EC should be properly calculated in the first place...)

ChrisAdderley commented 1 month ago

I tracked a possible issue into solar panel frame inconsistency at very high timewarp, so I've added more handling to that. I'd encourage testing with CT 1.6.6 and DBS 2.3.0