post-kerbin-mining-corporation / CryoTanks

Adds cryogenic fuel storage options and limited fuel switching to Kerbal Space Program
15 stars 30 forks source link

Updates for Procedural Fuel Tanks and Procedural Wings #129

Closed Scialytic closed 1 year ago

Scialytic commented 2 years ago

If there's anything you don't like or want me to change, I'm happy to fix it.

Procedural Fuel Tanks:

  1. Add liquid methane tank option (previously there was methalox but no option for methane alone).
  2. Improved consistency and hopefully easier maintainability of tank stats. Now most constants are read from the appropriate B9_TANK_TYPE definition using MM variables, and then derived values are computed from there. See code comments for details.
  3. Procedural TANK_TYPE_OPTION names now honor CryoTanks' localization, so the names are now consistent between ProceduralParts' tank type selector and the B9 switcher on normal parts.
  4. Normalized costs and added a convenient priceMultiplier to proportionally scale up the costs of procedural parts as judged appropriate. It's also easy for players to alter this value to suit their desires. In the attached pictures I set priceMultiplier to 1.0 just to demonstrate the cost parity with normal parts. I set it to 1.1 (i.e. 10% procedural surcharge) in the PR, but I'll happily change it to whatever you want.

I have tested both the normal and SMURFF versions in a clean-ish KSP install.

One important note is that the current ProceduralParts sometimes displays outdated dry mass in the PAW. I have submitted a PR for that https://github.com/KSP-RO/ProceduralParts/pull/306 but I don't know when the next release will be.

Old (Non-SMURFF): Non-SMURFF Old

New (Non-SMURFF): Non-SMURFF New-2 5 Non-SMURFF New-5 0 Non-SMURFF New-1 25 Non-SMURFF New-3 75

Old (SMURFF): SMURFF Old

New (SMURFF): SMURFF New-2 5 SMURFF New-5 0 SMURFF New-1 25 SMURFF New-3 75

Procedural Wings:

  1. Add liquid methane, methalox, and oxidizer-only tank options.
  2. Fix unbalanced resource amounts in LH2/Ox FuelSet. See code comments for details.
  3. FuelSet names now honor CryoTanks' localization, so the names are now consistent between PWing's selector and the B9 switcher on normal parts.

By default (mostly meaning no FAR wing mass-strength adjustment) PWing mass ratios are: LF,LF/Ox,Ox ~ 6 LCH4/Ox ~ 4.93 LCH4 ~ 3.13 LH2/Ox ~ 2.52 LH2 ~ 1.36

These seem reasonable for KSP, and in any case I don't see any way to adjust them. PWings does its own calculations where it assumes that 1 L really is 1 L, and wing mass/shape are dictated by structural/aerodynamic demands.

Old (note the insufficient Oxidizer): pWings Old

New: pWings New