search

post-kerbin-mining-corporation / CryoTanks

Adds cryogenic fuel storage options and limited fuel switching to Kerbal Space Program
15 stars 30 forks source link

Enabled boiloff with Modular Fuel Tanks #57

Closed dlrk2 closed 5 years ago

dlrk2 commented 5 years ago

Modified CryoTanksFuelTankSwitcher.cfg and CryoTanksProceduralFuelTanks.cfg to only block boil off when Real Fuels is used, not when modular fuel tanks is used

ChrisAdderley commented 5 years ago

I thought I'd merged this last night, but I guess I didn't!

Will be in the next set of updates.

ChrisAdderley commented 5 years ago

Actually, looked at the changes. It looks like you're just re-enabling the tank switcher component for cases when MFT is installed. This might not be what you want - it will add the part switching and stuff modules. Instead look at CryoTanksModularFuels, you may just want to enable the boiloff (not the switchers) in there?

dlrk2 commented 5 years ago

Yeah, that would have been a better ideal! I'll switch it around and redo the PR

On Mon, Nov 5, 2018 at 3:58 PM Chris Adderley notifications@github.com wrote:

Actually, looked at the changes. It looks like you're just re-enabling the tank switcher component for cases when MFT is installed. This might not be what you want - it will add the part switching and stuff modules. Instead look at CryoTanksModularFuels, you may just want to enable the boiloff (not the switchers) in there?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisAdderley/CryoTanks/pull/57#issuecomment-436032284, or mute the thread https://github.com/notifications/unsubscribe-auth/AZo8tfRnFsiyXZaNE8U5SHjamB6l0Tr_ks5usKZ2gaJpZM4YMqb2 .

ChrisAdderley commented 5 years ago

Good stuff. Also, please make sure to target the PR to dev, it saves some merge headaches.