search

post-kerbin-mining-corporation / CryoTanks

Adds cryogenic fuel storage options and limited fuel switching to Kerbal Space Program
15 stars 30 forks source link

One of the tanks has been losing fuel, but for some reason only one. #7

Closed abserver closed 8 years ago

abserver commented 8 years ago

output_log.txt

ChrisAdderley commented 8 years ago

This has to do with the old time warp bug. 1000 Ec/s is generated while there is only a capacity for say 2000 Ec/s on the ship. At high timewarp, it's possible for the demand from a single cryo tank to exceed the total remaining Ec on the ship, even through the power source is generating at a higher rate. In this example, at 100,000x timewarp and a physics rate of 0.02, the total draw from a 10Ec/s tank is 10x0.02x100000, or 20,000 Ec/tick. Even through the reactor generates 1000x0.02x100000 (2,000,000) Ec/tick, there is only 2000 Ec storage on the ship, so the tank fails to cool because it doesn't have the necessary immediate Ec.

This should be resolved in the next release by capping the timewarp scaling of cryo tank draw at 1000x, so it's assumed that if you have the power sources to supply power at 1000x warp, you are fine at all scales.

This can't be truly fixed without writing a shipwide resource broker, or preferably squad rewriting resource flow logic to solve rates before applying them to the storage.