Open Aebestach opened 3 months ago
Can you pare down the reproduction steps at all? My 'mimimum' multistar system test is GEP and I don't seem to get any errors.
RE: WDSP, having to support so many different solar panel implementations is not very great. At this point the permutations are going to get very large.
I was tested in Kcalbeloh, Kcalbeloh + KOP Is it possible to refer to Fusebox Continued and change it?
Can you let me know what version of Kopernicus you are using?
Yeah l guess a week ago the Kop method for managing solar panels changed completely so I'll have to rewrite this.
Can you let me know what version of Kopernicus you are using?
v211, I misunderstood the new KOP support in the update log as the rewritten KOP
The support that was added was for multiple stars in the planner which was all fine until then. Will have to work on it.
WDSP is implemented in the same way as the new KOP. If you want to adapt, please adapt it together. Thank you very much
Ok after talking to RTB about this, I can say the following things
kop-209
branch which adds some kind of support for the new method. It's not very tested though. We'll get a pathway forward in a bit to see how best to proceed.
The new KOP changes are my rewrite based on kerbalism, so I am also looking for ways to see if I can be compatible with them.
In the new KOP, the module name is this, which is obtained through the GetSolarPanelModule() method at https://github.com/Kopernicus/Kopernicus/blob/c0d9d09570a4df886afc012f456363263f0adad0/src/Kopernicus/Components/KopernicusSolarPanel.cs#L207 So is it possible to get the module name and then call the corresponding class?
I tested it in the kop-209 branch and found duplicate components. No issues found in the editor
In the new KOP, the module name is this, which is obtained through the GetSolarPanelModule() method at https://github.com/Kopernicus/Kopernicus/blob/c0d9d09570a4df886afc012f456363263f0adad0/src/Kopernicus/Components/KopernicusSolarPanel.cs#L207 So is it possible to get the module name and then call the corresponding class?
As I said here, I can add a variable in KOP to facilitate DBS to obtain the module name and then call the corresponding module. Can this variable help you?
I don't see duplicates here?
As I said here, I can add a variable in KOP to facilitate DBS to obtain the module name and then call the corresponding module. Can this variable help you?
Not really.
The panel of the ModuleCurvedSolarPanel
module will have this duplicate item
Ah yep, haven't fixed that one yet... but I guess this hack works so I'll move it over to dev.
By the way, I am reporting a mod that DBS does not recognize at present. It is Universal Storage II Finalized. US2 also has its own solar panel module, called USSolarSwitch
When switching back to the editor from the flight interface, the DBS data display is abnormal. You can see this video
KSP.log Hi Nertea, glad you updated your mod again. I installed the latest version of System Monitor and it still has compatibility issues with KOP's multi-star mode. In flight mode it looks like the picture. In VAB/SPH, the solar panels are identified as 0 EC/s.
I also have a feature request: Can you make WDSP compatible with System Monitor? WDSP is similar to the new KOP, but I added a few more variables to control the attenuation caused by weather.
Thank you so much