search

post-kerbin-mining-corporation / FarFutureTechnologies

Adds speculative, far-off technologies for mining, propulsion and power generation to Kerbal Space Program
28 stars 22 forks source link

Compatibility with PersistentThrust #115

Closed ra4nd0m closed 3 weeks ago

ra4nd0m commented 4 years ago

log + vid: https://drive.google.com/drive/folders/1JAxpAg2gAC3MFTiGI-1H9zAliNI3sMcR?usp=sharing Please note: the game was closed with Alt+F4

ChrisAdderley commented 4 years ago

Can you explain this? The video being in Russian kinda makes it hard to track what is going on. What I see is the engine stopping working when power runs out which is as expected.

ra4nd0m commented 4 years ago

Yes but despite it shows up like it does not produce any thrust (there are zeroes in "thrust" section. Actually it still produces little to no thrust as can be seen in the video that the ship is not falling but instead hovering on one place while slowly rising

ra4nd0m commented 4 years ago

Also please take a note at insanely fast changing numbers in the card. Those numbers should show current electricity consumption. Instead of showing zero they spontaneously change

ChrisAdderley commented 4 years ago

Oh, weird. Will have to look into that further - this engine is very stock in terms of code so maybe it is misconfigured somehow.

ra4nd0m commented 4 years ago

I repeatedly hover mouse around those.

  1. When electricity runs out the plume animation continues playing on full thrust
ChrisAdderley commented 4 years ago

I'll try to replicate it when work is over. Can't say much more than that now.

ra4nd0m commented 4 years ago

Still an issue in new version.

ChrisAdderley commented 4 years ago

I couldn't replicate it this morning. Do you have any other mods installed?

ra4nd0m commented 4 years ago

I found the culprit It was PersistentThrust Unfortuanly the only way to fix this is by completely removing it. That's a shame that such important mod for this pack is broken. Mabye this should be forwarded to PersistentThrust Github?

ra4nd0m commented 4 years ago

Right now I test other engines to find out how much engines are actually affected with this

ChrisAdderley commented 4 years ago

Quick look at the PersistentThrust source says that it adds itself to every engine. I could provide a patch to specifically remove it from engines that may have issues.

ra4nd0m commented 4 years ago

That would be a good idea. I will prepeare a list of affected engines.

ra4nd0m commented 4 years ago

Jp-10 is also affected.

ra4nd0m commented 4 years ago

I belive that this affects engines that require electric charge. Yup. Affected engines are JP-10 and NSWR. I think that since low-thrust engine affected this issue should be forwarded to PersistentThrust repo.

ChrisAdderley commented 4 years ago

Ok. I will not do anything for now, but if we get to release without a fix I will add a patch to disable PT on those engines.

parkerman-com commented 3 years ago

So will it work? persistent thrust? with all engines?

parkerman-com commented 3 years ago

Its not working persistent thrust, any reason ?

demonfiren commented 3 years ago

Its not working persistent thrust, any reason ?

It's been tagged "won't fix", what do you think that means?

ChrisAdderley commented 3 years ago

This needs to be fixed on persistent thrust's side, not mine.

ChrisAdderley commented 3 weeks ago

Closing due to above convo