post-kerbin-mining-corporation / FarFutureTechnologies

Adds speculative, far-off technologies for mining, propulsion and power generation to Kerbal Space Program
27 stars 20 forks source link

Fresnel Mirror Cell Fusion Engine shutdown #157

Closed the-emerald closed 3 years ago

the-emerald commented 3 years ago

Hello,

I've been experimenting with the Fresnel Mirror Cell Fusion Engine. I was able to get the built-in reactor started, however the temperature of the loop would heat up to 1600K (as expected), and then the engine immediately shuts down because it has overheated. This seems to be an issue that only happens with the Fresnel engine.

Kerbal Space Program Screenshot 2021 01 22 - 05 08 51 03

See attached for my test vessel.

ChrisAdderley commented 3 years ago

It's a known issue and will be dealt with in the next version.

the-emerald commented 3 years ago

I see. Would a temp fix like the PR help make it work meanwhile? Call me impatient... but I want to play with it!

ChrisAdderley commented 3 years ago

I've already changed it locally. Your fix would somewhat fix it, but note that it's the shutdown temperature that needs to be changed, not the outlet. With your PR, you now have a mix of systems outputting 1400 and 1600K, they should be consistent at 1600K

the-emerald commented 3 years ago

Ah, I see! The reactor should output at 1600K and have a higher shutdown temperature. Should I fix this, or close the PR as you've already implemented it? Cheers.

Edit: I didn't see the PR being closed. My bad!

On Fri, 22 Jan 2021, 05:53 Chris Adderley, notifications@github.com wrote:

I've already changed it locally. Your fix would somewhat fix it, but note that it's the shutdown temperature that needs to be changed, not the outlet. With your PR, you now have a mix of systems outputting 1400 and 1600K, they should be consistent at 1600K

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/post-kerbin-mining-corporation/FarFutureTechnologies/issues/157#issuecomment-764965227, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBH7O5GGRFR4ESUPCXIIE3S3CO4DANCNFSM4WNQRI3A .

the-emerald commented 3 years ago

May I know the new shutdown temperature by the way? I assume a quick fix like upping it to 1800K would work for now

ChrisAdderley commented 3 years ago

1800 is the new goal.

On Thu, Jan 21, 2021 at 2:25 PM Anson notifications@github.com wrote:

May I know the new shutdown temperature by the way? I assume a quick fix like upping it to 1800K would work for now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/post-kerbin-mining-corporation/FarFutureTechnologies/issues/157#issuecomment-764980782, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLBOUGEZYIA7FTWVUB75B3S3CSV5ANCNFSM4WNQRI3A .

ChrisAdderley commented 3 years ago

Changed in 1.1.0