post-kerbin-mining-corporation / FarFutureTechnologies

Adds speculative, far-off technologies for mining, propulsion and power generation to Kerbal Space Program
27 stars 21 forks source link

Atmosphere scoop is missing MinHarvestValue on all HARVESTED_RESOURCE nodes. #187

Closed 89Mods closed 2 months ago

89Mods commented 2 years ago

Context: I was trying to use the Atmosphere scoop to harvest LqdHe3 on Jool, but it did not pick up any at all until I let it de-orbit entirely. At 80km altitude, it finally started harvesting LqdHe3. Thousands of units per second, infact.

Instead of just reporting a bug, I found the problem. Similar to the exosphere scoop, the MinHarvestValue needs to be set on this part's harvest resources as well. The default value for this field (if not defined) is 0.0001, which is much higher than the concentration of LqdHe3 in Jool's upper atmosphere. I decided to define this value for all resources, to account for atmospheres that have lesser concentrations of those.

After applying the patch, the scoop successfully harvests a few units per second of LqdHe3 from Jool's upper atmosphere, which I believe is the intended behavior.