search

post-kerbin-mining-corporation / HeatControl

Adds more radiators to Kerbal Space Program
13 stars 15 forks source link

Typo? #1

Closed NathanKell closed 9 years ago

NathanKell commented 9 years ago

https://github.com/ChrisAdderley/HeatControl/blob/master/CModuleHeatPipe.cs#L110 Shouldn't it be parent for both? Or am I misunderstanding?

ChrisAdderley commented 9 years ago

As far as I determined, parent is the part the modular

ChrisAdderley commented 9 years ago

Object starts at, and tar

NathanKell commented 9 years ago

I mean, energy_target = targetThermalMass * targetTemp so energy_parent should be parent thermal mass * parent temp.

ChrisAdderley commented 9 years ago

Apologies Nathan, my phone is freaking out. I determined that target is where the pipe ends and parent is where it starts.

NathanKell commented 9 years ago

Right. And those heat contents aren't actually used (they're commented) but I think there's a typo in the linked one, hence the above comment.

ChrisAdderley commented 9 years ago

Ah I see. Yeah, typo. I stopped using that bit of code due to just using a temperature threshold rather than a heat content, for various balance based reasons.

ChrisAdderley commented 9 years ago

I will fix the typo though :)

NathanKell commented 9 years ago

No great importance, true, but figured I'd point it out as I noticed it, and I know those things can easily go undetected (ask me why I know that :P )