search

post-kerbin-mining-corporation / NearFutureLaunchVehicles

Adds huge rocket parts and advanced engines to Kerbal Space Program
18 stars 27 forks source link

unexpected tokens. (fix) #106

Closed Lisias closed 4 years ago

Lisias commented 4 years ago

Yeah. More lint. :)

Lisias commented 4 years ago

Hi!

How do I fix this pull request?

ChrisAdderley commented 4 years ago

Please target all PRs to dev.

Lisias commented 4 years ago

But it already is!!

Screen Shot 2020-07-26 at 17 55 15

ChrisAdderley commented 4 years ago

Well, your initial request was to master, which is why the integration checks ran, and why they failed. I'll merge this now as it looks fine.

Lisias commented 4 years ago

Now I got it. Adding a new commit would trick travis to recheck the pullrequest, or once travis rejects it, it's tainted for good and only a new pullrequest would solve the issue?

ChrisAdderley commented 4 years ago

Not quite. The Travis checks I have are only release level checks. They only run when a PR is targeted to master (which is the release branch). You targeted this to master, so it ran the release checks... which failed, because the version number has not been updated, etc.

Merging to dev does not run any checks at the moment, so everything is fine. The 'failed' stamp will remain though, because a check failed. Luckily I do not make passing mandatory on PRs.