search

post-kerbin-mining-corporation / NearFuturePropulsion

Adds advanced electric propulsion systems to Kerbal Space Program
35 stars 30 forks source link

Update NFPropulsionISRU.cfg #31

Closed gabevenberg closed 5 years ago

gabevenberg commented 8 years ago

first time using git, so i hope i did this right. replaces the mm cfg that adds a lithium refinery to the ISRUs. the old one only added the converters to the stock ones. this cfg looks for any converter that can convert ore into monoprop, and then adds an ore to lithium converter. keeps the same ratios, so the stock two will have the same stats as before, and scales it for third pary ISRUs based on their monoprop converters.

Wyzard256 commented 7 years ago

Nils277's Kerbal Planetary Base Systems has an ISRU part that would benefit from this. Currently, it doesn't get the lithium production added, nor the LH2 production from CryoTanks.

I made a patch to add the new module specifically to the planetary ISRU, but then found this. Now I'm wondering whether I should submit my patch as a separate pull request (though this one is better), release it separately (seems silly for a single small .cfg file), or wait and hope for this change to be merged.

gabevenberg commented 7 years ago

Really dont care. Nereta doesnt seem intrested in this, and im out a computer for now, but feel free to use this one for personal use, or even remind nereta about this. If you want your change in, not sure whether it would be better to put it here or kpbs. (I actually made it for kpbs and MKS, but it works for everything.)

Wyzard256 commented 7 years ago

Yeah, my comment was directed more at Nertea, as sort of a ping saying hey, this patch has specific real-world benefits; it's not just an abstract hypothetical improvement. I'm hoping to put it back onto the radar.

ChrisAdderley commented 7 years ago

I've merged the other patch for now. I prefer supporting specifics instead of all generality, I'll still continue to think about it.