search

post-kerbin-mining-corporation / NearFuturePropulsion

Adds advanced electric propulsion systems to Kerbal Space Program
35 stars 30 forks source link

Misleading "Power Level" label on VASIMR tweakable #61

Closed rspeed closed 7 years ago

rspeed commented 7 years ago

Parts that implement the VariableISPEngine module include a tweakable labeled "Power Level". That implies that it changes the engine's thrust, which it does, but the relationship is inverted – increasing the value for "Power Level" actually decreases thrust. Since the trade-off is between specific impulse and thrust, perhaps it would make more sense to have the label read "Efficiency".

Suprcheese commented 7 years ago

Agreed, "Power Level" is a tad confusing, considering the actual effects.

ChrisAdderley commented 7 years ago

But power != thrust... 🤕

rspeed commented 7 years ago

It is colloquially. And regardless, that slider doesn't alter the power requirements (unlike VariablePowerEngine).

ChrisAdderley commented 7 years ago

07b087952f4033e37399fb3fa7b0f5faa725664f, will be in first 1.3 build.