search

post-kerbin-mining-corporation / NearFutureSolar

Adds more solar panel parts to Kerbal Space Program
32 stars 25 forks source link

NearFutureSolar and tweakscale #9

Closed RealKolago closed 7 years ago

RealKolago commented 8 years ago

Is there a way to make NearFutureSolar compatible with tweakscale?

ChrisAdderley commented 8 years ago

You should ask the TweakScale guys about this, I don't support TweakScale myself.

RealKolago commented 8 years ago

Please take a look here: http://github.com/pellinor0/TweakScale/issues/6

"I had a look in https://github.com/ChrisAdderley/NearFutureSolar/blob/master/ModuleCurvedSolarPanel.cs

The problem seems to be that TotalEnergyRate is used only once to calculate chargePerTransform, probably this is done before TweakScale tries to scale it. chargePerTransform can not be scaled because it is not a kspField.

In my opinion this is best solved in NF-Solar, by evaluating TotalEnergyRate directly in the fixedUpdate method.

EDIT: I am working on a pull request for NF-Solar"

ChrisAdderley commented 8 years ago

Will look at verifying this for next version.

ChrisAdderley commented 7 years ago

Finally fixed in the next version