post-kerbin-mining-corporation / StationPartsExpansionRedux

Adds an extensive set of space station parts to Kerbal Space Program
54 stars 43 forks source link

Excessive background food consumption when greenhouse is on #316

Open pdg137 opened 1 year ago

pdg137 commented 1 year ago

There's a closed issue over at https://github.com/KSP-RO/TacLifeSupport/issues/112 about how background food usage is sometimes 60x too high when a SSPXr greenhouse is activated. Changing the number on this line to zero fixes it:

https://github.com/post-kerbin-mining-corporation/StationPartsExpansionRedux/blob/dev/GameData/StationPartsExpansionRedux/Patches/SSPXR-TACLS-00.cfg#L157

I don't know what the mineral siphon is for or what that number means, but there's definitely something wrong. Since TAC is apparently no longer being maintained I wonder if this can be fixed somehow in this mod.

JadeOfMaar commented 1 year ago

That SSPX TAC config is mine. The reason for it existing is that the included greenhouse setup uses Minerals like non-TAC greenhouses would use USI's Fertilizer, but since TAC really doesn't care for ISRU (drilling and refining things and making better use of Waste and WasteWater) it seemed like a good idea to provide an option to extract Minerals from excess Food if the player ever decided there was too much Food.

To resolve this issue and possible others, and allow for someone to update/fix these patches conveniently, they would need to be separated and published as their own download/modlet so they aren't dragged down by being part of a huge download and its restrictive license (SSPXR).