post-kerbin-mining-corporation / SystemHeat

Adds an improved thermal mechanics experience to Kerbal Space Program.
16 stars 18 forks source link

Use MaximumBoiloffScale in cryo tank boiloff radiation calculations. #104

Closed Starstrider42 closed 6 months ago

Starstrider42 commented 1 year ago

The previous radiative boiloff code clamped radiative effects to MinimumBoiloffScale, but left MaximumBoiloffScale unused. This seems to have been an oversight in the original CryoTanks implementation.

Having an upper bound is essential to playing cryo tanks with LongwaveFluxAffectsBoiloff, because the KSP body flux has unphysical orientation-dependent spikes (100-1000× solar).

This PR should be released together with post-kerbin-mining-corporation/CryoTanks#132, to maintain consistency.