search

post-kerbin-mining-corporation / Waterfall

Mesh-driven engine effect framework for Kerbal Space Program
57 stars 19 forks source link

Engine lights have incorrect layer setup #130

Open JonnyOThan opened 9 months ago

JonnyOThan commented 9 months ago

I haven't tested this, but I'm pretty sure this is why you sometimes see bright lights inside IVA after takeoff when waterfall is installed. Since the internal space and external spaces are in different coordinate systems, and the lights are in both layers, then they show up in the internal space but at weird positions (using their external coordinates, not where the engines appear to be).

image

If we wanted to support engine lights in IVA, there would need to be new code to make a copy of the light at the correct coordinates and layer, then keep it in sync with the external one. Not terribly hard, but just fixing the layers on the light model will at least fix the bug.

JonnyOThan commented 5 days ago

did you fix this one? cause I didn't... it needs to be updated in the .mu file. I don't see any updates in the dev branch

ChrisAdderley commented 5 days ago

It's fixed locally in the particles branch. Once that gets moved to dev it'll be sorted