search

post-kerbin-mining-corporation / WaterfallRestock

Adds Waterfall effect configurations to the Restock and Restock+ Kerbal Space Program mods
9 stars 10 forks source link

Engine flameout effects rotated 90 degrees #24

Open Gessalt opened 2 years ago

Gessalt commented 2 years ago

I have noticed a bug with all engines that are calling the prefab particle fx_exhaustSparks_flameout_2. When an engine with this effect experiences a flameout, the flameout particle effect is rotationally offset 90 degrees from the direction of the plume.

I wasn't able to nail down where exactly the problem is occurring, it seems to be isolated to engines within Restock with that flameout effect applied (such as the Reliant). Engines within restock that do not have this effect (such as the Terrier) and engines outside of Restock with Waterfall configs that use that flameout effect (such as the KS-10AJ from NFLV) do not exhibit this glitch.

I have tested and confirmed that this happens in an entirely fresh KSP install with only Restock, Waterfall, WaterfallRestock, and Module Manager installed. Attached below are some images demonstrating this occurring both on the ground and in-flight.

20211106172122_1 20211106172806_1

Gessalt commented 2 years ago

I just did some deeper looking into the configs, and I realized that there was one difference between how NFLV was setting up the flameout effect and how WaterfallRestock was: NFLV gives fx_exhaustSparks_flameout_2 a transform name of thrustTransform, whereas WaterfallRestock uses the transform name of smokePoint. Sure enough, switching smokePoint to thrustTransform seems to correct the issue- the flameout sparks particle effect is now inline with the direction of thrust.

I am going to go ahead and leave this issue open for now as I do not know enough about what WaterfallRestock is doing to say that this fixes all of the problem.