search

postaddictme / instagram-php-scraper

Get account information, photos, videos, stories and comments.
https://packagist.org/packages/raiym/instagram-php-scraper
MIT License
3.1k stars 800 forks source link

Ошибка getMediaCommentsByCode, если code неправильный #112

Closed mypostofice24 closed 5 years ago

mypostofice24 commented 7 years ago

Если функции getMediaCommentsByCode передать неверный code она выдает следующее: Notice: Undefined index: comments in /Users/andrey/Desktop/Projects/incubator/insta/vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php on line 271

Warning: Invalid argument supplied for foreach() in /Users/andrey/Desktop/Projects/incubator/insta/vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php on line 272

Notice: Undefined index: comments in /Users/andrey/Desktop/Projects/incubator/insta/vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php on line 275

Notice: Undefined index: comments in /Users/andrey/Desktop/Projects/incubator/insta/vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php on line 276

Предлагаю добавить проверку в данной функции в строке: 271 if(empty($jsonResponse['comments'])) { throw new InstagramException('Something went wrong. Please report issue.'); }

raiym commented 7 years ago

Спасибо проверим. Если считаете, что можете улучшить код, то открывайте pull request. будем рады

raiym commented 5 years ago

still issue

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.