search

postaddictme / instagram-php-scraper

Get account information, photos, videos, stories and comments.
https://packagist.org/packages/raiym/instagram-php-scraper
MIT License
3.08k stars 798 forks source link

Cover with test cases #89

Closed raiym closed 6 years ago

raiym commented 7 years ago

Each function provided in Instagram.php

jetonr commented 7 years ago

I can help with testing! What do you need ?

raiym commented 7 years ago

@jetonr thank you.

There are some functions in api that doesn't have test cases (like tags pagination), if you want you can start adding test cases and create PR.

elliott-beach commented 7 years ago

I'm going to write tests for 3-4 functions and make a PR, then maybe do more.

However, there are too many unaddressed open issues in this project, which may be more important for maintenance than tests. People will assume a project with many issues not addressed by the maintainer is abandoned.

Issues that should be closed immediately include #127, #125, #118, #116, #115, #89, #81, and possibly #119.

raiym commented 7 years ago

@e-beach thank you Elliot for being part of this library

elliott-beach commented 7 years ago

@raiym Do you know why testGetMediaCommentsByCode is failing? In particular, why is the expected size exactly 4 less than the value of $count in the first place?

Intuitively, I'd expect the sizeof($comments) to be 40. https://github.com/postaddictme/instagram-php-scraper/blob/dcfc4b0ac1247ba55c8e1ecf026cb33eb6a0c456/tests/InstagramTest.php#L110