Postal 2.0.3: _.noConflict() unbinds lodash from window

postaljs / postal.js

JavaScript pub/sub library supporting advanced subscription features, and several helpful add-ons.

http://ifandelse.com

MIT License

2.83k stars 193 forks source link

Closed scanarjo closed 8 years ago

scanarjo commented 8 years ago

I added postal.js 2.0.3 to our app which already relies heavily on lodash.

After loading postal the app no longer works as lodash has been unbound from window. due to the call to .noConflict() when postal is loaded.

The change was introduced here: d9bd448ea0853fb8d93b0efd398e7985c167b131.

(PS: I hope I've not misunderstood something basic!)

ifandelse commented 8 years ago

@scottaj91 apologies for the headache on this. I will look into it and get a fix up.

scanarjo commented 8 years ago

@ifandelse Brilliant. Much appreciated. Have reverted to 2.0.0 for now.

ifandelse commented 8 years ago

@scottaj91 give v2.0.4 a shot and let me know if that clears things up for you.

scanarjo commented 8 years ago

Yeah the conditional guard you put in has fixed the issue for our app. Thanks for the quick turnaround! :)