postalsys / imapflow

IMAP Client library for EmailEngine Email API (https://emailengine.app)
https://imapflow.com
Other
350 stars 59 forks source link

Advanced OAuth2 handling #177

Closed PRR24 closed 6 months ago

PRR24 commented 6 months ago

Please consider adding advanced OAuth2 handling to the IMapFlow, namely:

Thank you.

andris9 commented 6 months ago

ImapFlow does not handle OAuth2 internally. It takes the accessToken value, and if authentication fails, you are supposed to generate a new token.

benbucksch commented 4 months ago

@andris9 This makes sense to keep OAuth2 login out of scope.

PRR24 commented 4 months ago

To be honest, it sounds reasonable for me as well. The trigger behind the request was that for some reason, the OAuth handling was considered to be in scope for NodeMailer. As I am using both of these great libraries, this discrepancy was weird for me and I would prefer to use the exact same approach for both cases, either delegating it to the library or using some other / my own implementation.