Fix DOS issue on fixLineBuffer

postalsys / mailauth

Command line utility and a Node.js library for email authentication

Other

127 stars 10 forks source link

Fix DOS issue on fixLineBuffer #65

Closed baptistejamin closed 2 months ago

baptistejamin commented 2 months ago

As explained on https://github.com/postalsys/mailauth/issues/64 , there is a DOS issue with the fixLineBuffer function.

This patch fixes the issue.

Since we couldn't catch the exact mail content creating this issue, I added a test script that creates a very long line email: https://github.com/postalsys/mailauth/issues/64#issuecomment-2295902343

CLAassistant commented 2 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Baptiste Jamin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

titanism commented 2 months ago

ping @andris9

titanism commented 2 months ago

The crisp folks fixing an issue we had for @forwardemail too, thanks many 🙏 🚀

andris9 commented 2 months ago

@baptistejamin Thank you, but in order to merge the PR, I would have to ask you to sign the CLA as instructed in the comment above. If you are not able to, then let me know, and I'll implement a similar fix myself.

baptistejamin commented 2 months ago

@andris9 You can do whatever you want with the PR

andris9 commented 2 months ago

Fixed in https://github.com/postalsys/mailauth/releases/tag/v4.6.9 I was not able to use the PR without a CLA, but I implemented a similar fix.