search

postcode-nl / PostcodeNl_Api_Magento2

A Magento 2 plugin that implements the Postcode.nl international address API
https://developer.postcode.eu/documentation/
BSD 2-Clause "Simplified" License
10 stars 13 forks source link

Translations #5

Closed gerben86 closed 4 years ago

gerben86 commented 4 years ago

It would be a big improvement if there were translations (or at least a i18n dir and files) provided so it's easier to customize the extension and the frontend. Now everything is in English by default.

JozefVerhoef commented 4 years ago

Which texts would you like to be able to translate?

Any text that is part of the autocomplete drop down comes from the Postcode.nl API response, which is in the language determined by the configured store language.

For supported API languages, see the language parameter described at https://api.postcode.nl/documentation/international/v1/Autocomplete/autocomplete

gerben86 commented 4 years ago

I saw at least those 2 on the frontend:

  1. Address validation -> Rename to something like:"Adres validatie"
  2. Fill out your postcode and housenumber to auto-complete your address. -> Rename to something like: "Vul uw postcode en huisnummer in om uw adres te zoeken"

But we disabled the plugin again, so not able to see if there are any other sentences which should be translated also.

ZIPITRO commented 4 years ago

It would be a big improvement if there were translations (or at least a i18n dir and files) provided so it's easier to customize the extension and the frontend. Now everything is in English by default.

Would be indeed a big + to have all strings translated or to be able to use data-binding with ko.

JozefVerhoef commented 4 years ago

This has been improved in the latest release