search

postcode-nl / PostcodeNl_Api_Magento2

A Magento 2 plugin that implements the Postcode.nl international address API
https://developer.postcode.eu/documentation/
BSD 2-Clause "Simplified" License
10 stars 13 forks source link

Add manual entry link - Not working #68

Closed JelleGe closed 1 year ago

JelleGe commented 1 year ago

The function "Add manual entry link" does not work anymore with the latest version 3.1.9, even it is enabled in the backend settings. This option is not shown in frontend.

JerrySmidt commented 1 year ago

The manual entry link only applies to the autocomplete field and not to the postcode + house number fields. And is shown when the autocomplete field has an error (e.g. on blur with incomplete address).

I've just compared versions 3.1.8 and 3.1.9 and the link behaves the same in both.

Is the link still missing if you have an error shown on the autocomplete field?

JelleGe commented 1 year ago

Sadly with the latest version the manual entry link is not shown, when the autocomplete has an error. When we fill in a wrong house number with postcode combination, the house number field shows an error with the message; the address could not be found. We come from 3.1.7.1 and it works well in that version.

JerrySmidt commented 1 year ago

This option only applies to the single autocomplete field. It was never implemented for the postcode + house number fields (same in 3.1.7.1).

See also https://github.com/JerrySmidt/PostcodeNl_Api_Magento2/issues/42

JelleGe commented 1 year ago

Hmm well it does works on 3.1.7.1 with the postcode + house number field. But will this be added also for postcode + house number fields in a future release?

JerrySmidt commented 1 year ago

Sure, perhaps we'll add this in the future.