search

postcode-nl / PostcodeNl_Api_Magento2

A Magento 2 plugin that implements the Postcode.nl international address API
https://developer.postcode.eu/documentation/
BSD 2-Clause "Simplified" License
10 stars 13 forks source link

Check in Javascript if variables are set when initializing the module (#77) #78

Open Paulsky opened 1 year ago

Paulsky commented 1 year ago

Issue: #77 Check in Javascript if childHouseNumberSelect and this.settings are defined

JerrySmidt commented 1 year ago

Hi Paulsky,

While your PR does seem to get rid of errors as reported in #77, now the result is that field validation is missing when this.settings is not defined.

This only works around the issue that settings are in some cases undefined. But for now it is not clear exactly how to reproduce the undefined settings. This needs to be known first so that we can test it. And more importantly, find the root cause and get it fixed.