postcode-nl / PostcodeNl_Api_MagentoPlugin

A Magento plugin 1.9 that implements the Postcode.nl API for Dutch addresses
BSD 2-Clause "Simplified" License
21 stars 12 forks source link

Fix check for migrating old configuration settings #17

Closed aadmathijssen closed 9 years ago

aadmathijssen commented 9 years ago

The check whether there is an old configuration always returns true, even for new installations: the call to Mage::getStoreConfig('postcodenl/config/api_secret') returns either null (new installations) or a string (old installations), but the call to trim always results in a string; therefore the !== null comparison always returns true.