postcode-nl / PostcodeNl_Api_MagentoPlugin

A Magento plugin 1.9 that implements the Postcode.nl API for Dutch addresses
BSD 2-Clause "Simplified" License
21 stars 12 forks source link

OneStepCheckout 4.5.4 - cannot place order when PostcodeAPI plugin is enabled #29

Closed hans2103 closed 5 years ago

hans2103 commented 8 years ago

@speedupmate
Updated OneStepCheckout to version 4.5.4 When PostcodeAPI is activated I cannot place an order. When I set "Handmatig adres invullen" and fill out the address manually I'm able to place an order. There is no message to be seen when pressing the button. no visible error to be seen.

hans2103 commented 8 years ago

placing the order only seems to work when I apply the override on js/postcodenl/api/lookup.js suggested by Anton (@speedupmate) in #28

OPEN js/postcodenl/api/lookup.js FIND if (PCNLAPI_CONFIG.showcase && data.showcaseResponse) ADD BEFORE

    //OneStepCheckout support change to remap the fields, address element id -s have been changed
    var street1 = 'street0', var street2 = 'street1';

SAVE&CLOSE

hans2103 commented 8 years ago

I didn't create a pull request, since I haven't tested it on other checkout plugins.

mrterhorst commented 8 years ago

UPDATE: as pointed out by @speedupmate this statement is invalid.

Thanks for the catch.

This applies to Idev's Onestepcheckout (onestepcheckout.com) v4.5.5 as well.

speedupmate commented 8 years ago

no it does not apply to 4.5.5. if you have the issue with 4.5.5 then you have not updated all templates app/design/frontend/base/default/template/onestepcheckout/billing_fields.phtml app/design/frontend/base/default/template/onestepcheckout/shipping_fields.phtml