search

postcode-nl / PostcodeNl_Api_MagentoPlugin

A Magento plugin 1.9 that implements the Postcode.nl API for Dutch addresses
BSD 2-Clause "Simplified" License
21 stars 12 forks source link

This pull would add functionality to auto enable the manual input option #5

Closed sg3s closed 10 years ago

sg3s commented 10 years ago

One of the possible error messages suggests to use manual input instead, but it is vague to the user exactly what he/she needs to do at that moment (clicking the checkbox). This automates that action, and keeps the error message.

DaanBroekhof commented 10 years ago

Thank you for your contribution! Unfortunately I overlooked it when pushing the last 1.1.0.0 version changes, but will merge & integrate it for the next version.

sg3s commented 10 years ago

Something that occured to me just now; this adds the feature for billing, but skips the switch to manual action when the check is done for shipping postcode. Slight oversight, I would add a commit to fix that but I don't quite have the time to test it too.

DaanBroekhof commented 10 years ago

Yeah I saw that too, but I have a fix for that which I will do in the merge.

DaanBroekhof commented 10 years ago

Hmm apparently my merge-conflict method commit https://github.com/postcode-nl/PostcodeNl_Api_MagentoPlugin/commit/ac71eeb1f8ff8181a08fae8626e683dac9bc5338 was not a neat & tidy pull request resolve for github :/