New plugin options argument, and other fixes

postcss / gulp-postcss

Pipe CSS through PostCSS processors with a single parse

MIT License

769 stars 65 forks source link

New plugin options argument, and other fixes #150

Closed ZeeCoder closed 5 years ago

ZeeCoder commented 5 years ago

All the changes:

Removed deprecated usages of new Buffer()
Accepts a new third pluginOptions parameter with handleResult, which allows us to handle the results from PostCSS. (For example: handling messages from PostCSS plugins, which was not possible before.)
Declared the supported node version in package.json

ZeeCoder commented 5 years ago

Note that sourcemap test fails in master as well. 🤷‍♂️

ZeeCoder commented 5 years ago

Any chance this could get looked at? cc @ai @w0rm

ai commented 5 years ago

.idea should be in your local git ignore, not in global

ai commented 5 years ago

I can move and release it (if I have a rights) if CI will be fixed

ZeeCoder commented 5 years ago

I might need help on that, as I said it's not my changes that break the CI, it's failing in the current master too.

ai commented 5 years ago

Sorry, you need to wait for @w0rm. I am very bad at Gul plugins.

w0rm commented 5 years ago

@ZeeCoder can you open an issue that explains your specific use case? An API that allows to pass a callback that can modify postcss result seems a bit hacky to me:

I'd rather not have any configuration that is not a part of https://www.npmjs.com/package/postcss-load-config
what you try to address seems to be a shortcoming of gulp, where the only output is a vinyl file. A stream of files that uses side effects to extract additional stuff feels a bit wrong.

As for buffer.from, could you please open a separate PR for it?

Let's not modify the changelog, it should be done only when a new version is published.

ZeeCoder commented 5 years ago

Closed in favour of #151 and #152