chore: bump postcss version to 8

postcss / gulp-postcss

Pipe CSS through PostCSS processors with a single parse

MIT License

769 stars 65 forks source link

chore: bump postcss version to 8 #162

Closed m4thieulavoie closed 4 years ago

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling c0519ac00c0e79b34c778ec4ec640870f2748314 on m4thieulavoie:chore/postcss-major-bump into 5f92ee0bf167eb5337b46a8dbaa10f0a053bf90a on postcss:master.

m4thieulavoie commented 4 years ago

Could use some eyes on this @ai @w0rm

ai commented 4 years ago

You need to do a few extra steps

https://github.com/postcss/gulp-postcss/issues/161

m4thieulavoie commented 4 years ago

You need to do a few extra steps

161

Done, I hope it's okay this way 😄

ai commented 4 years ago

I released postcss-load-config 2.1.1. Can you update it in PR?

m4thieulavoie commented 4 years ago

I released postcss-load-config 2.1.1. Can you update it in PR?

Done!

w0rm commented 4 years ago

Looks like the tests are failing because postcss has been moved into peerDependencies

m4thieulavoie commented 4 years ago

Looks like the tests are failing because postcss has been moved into peerDependencies

Added in in devDependencies so the tests pass

w0rm commented 4 years ago

Tests are failing because node 6 is not supported. We need to update travis.yml to test in:

node_js:
  - node
  - "12"
  - "10"

Also the engines setting in package.json needs to reflect the one from postcss: https://github.com/postcss/postcss/blob/master/package.json#L6

m4thieulavoie commented 4 years ago

Tests are failing because node 6 is not supported. We need to update travis.yml to test in:
node_js:
  - node
  - "12"
  - "10"
Also the engines setting in package.json needs to reflect the one from postcss: https://github.com/postcss/postcss/blob/master/package.json#L6

Thanks, the build is finally ✅

w0rm commented 4 years ago

@m4thieulavoie thanks for your PR, I will cut a release shortly