postcss / gulp-postcss

Pipe CSS through PostCSS processors with a single parse
MIT License
769 stars 65 forks source link

Why does the new version 9.1.0 not comply with semver about engines.node? #188

Closed shiftj18 closed 10 months ago

shiftj18 commented 10 months ago

image

image

image

shiftj18 commented 10 months ago

Shouldn't the node version be compatible with the x of the semver rule?

This causes packages or apps using the '^9.0.1' version to abort unexpectedly, when installed using the yarn(v1) package manager in an earlier version of the node environment. Eventually, the installation failed, and the directory 'node_modules' is not exists.

"error gulp-postcss@9.1.0: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.15.0" error Found incompatible module.'
shiftj18 commented 10 months ago

image

w0rm commented 10 months ago

Hey @shiftj18. No particular reason. An oversight on my side.

shiftj18 commented 10 months ago

Hey @shiftj18. No particular reason. An oversight on my side.

Can you fix it?

Rollback latest to 9.0.1, and deprecated 9.1.0.

Then, use the major version to carry the 16 to 18 changes to 'engines.node', like 10.0.0.

w0rm commented 10 months ago

@shiftj18 I will try do as you’ve suggested. Seems reasonable to me

w0rm commented 10 months ago

@shiftj18 done! Thanks for reporting