postcss / postcss-bem-linter

A BEM linter for postcss
MIT License
572 stars 35 forks source link

Get build to pass #34

Closed davidtheclark closed 9 years ago

davidtheclark commented 9 years ago

I don't understand the latest failure. Again, it's related to JSCS: looks like it didn't install properly on Travis (?), but I can't guess why.

May be that this would be solved with a switch to ESLint: https://github.com/necolas/postcss-bem-linter/issues/29

necolas commented 9 years ago

Sorry I'm not able to help out right now. Below is an eslint config we are using on a twitter project.

If there are loads of eslint errors, I'd be fine with disabling linting until someone has time / interest in resolving the errors. Don't want the linting to get in the way of doing things :)

{
  "env": {
    "browser": false,
    "es6": false,
    "mocha": true,
    "node": true
  },
  "rules": {
    // based on https://github.com/feross/standard
    "block-scoped-var": 0,
    "brace-style": [2, "1tbs", { "allowSingleLine": true }],
    "camelcase": 0,
    "comma-dangle": [2, "never"],
    "comma-spacing": [2, { "before": false, "after": true }],
    "comma-style": [2, "last"],
    "complexity": 0,
    "consistent-return": 0,
    "consistent-this": 0,
    "curly": [2, "multi-line"],
    "default-case": 0,
    "dot-notation": 0,
    "eol-last": 2,
    "eqeqeq": [2, "allow-null"],
    "func-names": 0,
    "func-style": [0, "declaration"],
    "generator-star-spacing": [2, "both"],
    "guard-for-in": 0,
    "handle-callback-err": [2, "^(err|error|anySpecificError)$" ],
    "indent": [2, 2],
    "key-spacing": [2, { "beforeColon": false, "afterColon": true }],
    "max-depth": 0,
    // 'max-len' deviates from 'standard'
    "max-len": [2, 80, 4],
    "max-nested-callbacks": 0,
    "max-params": 0,
    "max-statements": 0,
    "new-cap": [2, { "newIsCap": true, "capIsNew": false }],
    "new-parens": 2,
    "no-alert": 2,
    "no-array-constructor": 2,
    "no-bitwise": 0,
    "no-caller": 2,
    "no-catch-shadow": 0,
    "no-cond-assign": 2,
    "no-console": 0,
    "no-constant-condition": 0,
    "no-control-regex": 2,
    "no-debugger": 2,
    "no-delete-var": 2,
    "no-div-regex": 0,
    "no-dupe-args": 2,
    "no-dupe-keys": 2,
    "no-duplicate-case": 2,
    "no-else-return": 0,
    "no-empty": 0,
    "no-empty-class": 2,
    "no-empty-label": 2,
    "no-eq-null": 0,
    "no-eval": 2,
    "no-ex-assign": 2,
    "no-extend-native": 2,
    "no-extra-bind": 2,
    "no-extra-boolean-cast": 2,
    "no-extra-parens": 0,
    "no-extra-semi": 0,
    "no-extra-strict": 0,
    "no-fallthrough": 2,
    "no-floating-decimal": 2,
    "no-func-assign": 2,
    "no-implied-eval": 2,
    "no-inline-comments": 0,
    "no-inner-declarations": [2, "functions"],
    "no-invalid-regexp": 2,
    "no-irregular-whitespace": 2,
    "no-iterator": 2,
    "no-label-var": 2,
    "no-labels": 2,
    "no-lone-blocks": 2,
    "no-lonely-if": 0,
    "no-loop-func": 0,
    "no-mixed-requires": [0, false],
    "no-mixed-spaces-and-tabs": [2, false],
    "no-multi-spaces": 2,
    "no-multi-str": 2,
    "no-multiple-empty-lines": [2, { "max": 1 }],
    "no-native-reassign": 2,
    "no-negated-in-lhs": 2,
    "no-nested-ternary": 0,
    "no-new": 2,
    "no-new-func": 2,
    "no-new-object": 2,
    "no-new-require": 2,
    "no-new-wrappers": 2,
    "no-obj-calls": 2,
    "no-octal": 2,
    "no-octal-escape": 2,
    "no-path-concat": 0,
    "no-plusplus": 0,
    "no-process-env": 0,
    "no-process-exit": 0,
    "no-proto": 2,
    "no-redeclare": 2,
    "no-regex-spaces": 2,
    "no-reserved-keys": 0,
    "no-restricted-modules": 0,
    "no-return-assign": 2,
    "no-script-url": 2,
    "no-self-compare": 2,
    "no-sequences": 2,
    "no-shadow": 0,
    "no-shadow-restricted-names": 2,
    "no-spaced-func": 2,
    "no-sparse-arrays": 2,
    "no-sync": 0,
    "no-ternary": 0,
    "no-throw-literal": 2,
    "no-trailing-spaces": 2,
    "no-undef": 2,
    "no-undef-init": 2,
    "no-undefined": 0,
    "no-underscore-dangle": 0,
    "no-unreachable": 2,
    "no-unused-expressions": 0,
    "no-unused-vars": [2, { "vars": "all", "args": "none" }],
    "no-use-before-define": 0,
    "no-var": 0,
    "no-void": 0,
    "no-warning-comments": [0, { "terms": ["todo", "fixme", "xxx"], "location": "start" }],
    "no-with": 2,
    "no-wrap-func": 2,
    "one-var": 0,
    "operator-assignment": [0, "always"],
    "padded-blocks": [2, "never"],
    "quote-props": 0,
    "quotes": [2, "single", "avoid-escape"],
    "radix": 2,
    // 'semi' deviates from 'standard'
    "semi": [2, "always"],
    "semi-spacing": 0,
    "sort-vars": 0,
    "space-after-keywords": [2, "always"],
    "space-before-blocks": [2, "always"],
    // 'space-before-function-parentheses' deviates from 'standard'
    "space-before-function-parentheses": [2, {"anonymous": "always", "named": "never"}],
    "space-in-brackets": 0,
    "space-in-parens": [2, "never"],
    "space-infix-ops": 2,
    "space-return-throw-case": 2,
    "space-unary-ops": [2, { "words": true, "nonwords": false }],
    "spaced-line-comment": [2, "always"],
    "strict": 0,
    "use-isnan": 2,
    "valid-jsdoc": 0,
    "valid-typeof": 2,
    "vars-on-top": 0,
    // 'wrap-iife' deviates from 'standard'
    "wrap-iife": [2, "outside"],
    "wrap-regex": 0,
    "yoda": [2, "never"]
  }
}
davidtheclark commented 9 years ago

If you'd like me to implement that ESLint config I'm happy to. Will get to it within the next couple of days I think.

necolas commented 9 years ago

OK. I noticed the build is failing; I might have merged 2 "passing" branches too quickly, with the second failing once the first was merged.

davidtheclark commented 9 years ago

Huh. Hopefully the latest PRs will fix it?

necolas commented 9 years ago

Looks good now