search

postcss / postcss-cli

CLI for postcss
Other
840 stars 93 forks source link

fixes issue with maps flag not working #185

Closed kvnlnt closed 6 years ago

kvnlnt commented 6 years ago

Cli arguments seem to be handled differently in different environments. From within the tests (using execFile) all is well (therefore they're passing), however when using a standard cli (zsh) the structure of the options looks very different. Do a dump of options while running tests (index.js ~:189ish after options is set) and you'll see that the maps key is present when the -m flag is set. However, if you run postcss as a package from a project, you'll see that the maps key is now missing.

The main problem is the missing "maps" key when sending the options object to the process method. Not wanting to make too big of a change I copied the options object back on the the ctx object to avoid any problems.

All tests are passing except 'error invalid --config' but that appears to be a pre-existing issue.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 76.0% when pulling 7ee7a2a8b067550030a04e403ab618ff44b0b77c on kvnlnt:master into 61349474ba9e9d16ac3752d9cc80959f391749d2 on postcss:master.

RyanZim commented 6 years ago

v5 changes this; assuming it's fixed.