Avoid joining void paths by passing cwd to the globber

postcss / postcss-cli

CLI for postcss

Other

840 stars 93 forks source link

Avoid joining void paths by passing cwd to the globber #262

Closed manuelmazzuola closed 5 years ago

manuelmazzuola commented 5 years ago

fix https://github.com/postcss/postcss-cli/issues/261

coveralls commented 5 years ago

Coverage remained the same at 75.342% when pulling 54224bfcfd139852d7f044ff1e687034d75bc196 on ClouDesire:glob-issue into f2aba4918ee9a0a8f0ffae886ab2326d1e6ad544 on postcss:master.

RyanZim commented 5 years ago

According to https://github.com/mrmlnc/fast-glob#cwd; the default is already process.cwd(), so I'm not seeing what this changes?

manuelmazzuola commented 5 years ago

I don't know but without this change postcss-cli doesn't work for me. I have postcss-cli 6.1.1, node 10.15.0 and fast-glob 2.2.4 :man_shrugging:

manuelmazzuola commented 5 years ago

You mentioned fast-glob but according to the package.json postcss-cli uses globby based on fast-glob, and look at this diff, commited 5 hours ago: https://github.com/sindresorhus/globby/commit/d80422881de179c23726bbddd02c0402a797186b#diff-168726dbe96b3ce427e7fedce31bb0bcL50

RyanZim commented 5 years ago

Trying doing a fresh install of postcss-cli, so you get globby 8.0.2, and see if that fixes your issue. Refs https://github.com/sindresorhus/globby/pull/99#issuecomment-452647305.

manuelmazzuola commented 5 years ago

They have fixed so I'll close this one.