search

postcss / postcss-cli

CLI for postcss
Other
836 stars 93 forks source link

Error when using unsupported PostCSS version (#361) #362

Closed thinkverse closed 3 years ago

thinkverse commented 3 years ago

Added the postcss version check @ai talked about. Changed the wording a bit and used the built-in error function.

As for testing this functionality, not going to lie. I couldn't get this error to throw ones, even did the steps mentioned in the issue (#361) by using npm link to this version and installing plugins that use PostCSS 7 and it builds the CSS file and didn't throw a single error.

Seems like this error might be thrown very rarely? But I do hope it helps in the long run. 🙂

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 81.41% when pulling e140a296a9102653249ac383703d448da07fe020 on thinkverse:unsupported-postcss-version-error into 4b9b66d5338b925ec6b52e2fd4bb1e5901038fbc on postcss:master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 81.41% when pulling e140a296a9102653249ac383703d448da07fe020 on thinkverse:unsupported-postcss-version-error into 4b9b66d5338b925ec6b52e2fd4bb1e5901038fbc on postcss:master.

ai commented 3 years ago

@RyanZim this PR is ready to merge. My yarn/npm error message suggestion is not a blocker to merge and release it (especially since a lot of users have this problem right now).

thinkverse commented 3 years ago

I tried to find a good solution to the auto-discovery of the package manager but to no avail. Could keep looking for a solution for a later PR though of the feature is really needed.

RyanZim commented 3 years ago

KISS; no need for any fancy auto-detection. LGTM