search

postcss / postcss-color-function

PostCSS plugin to transform W3C CSS color function to more compatible CSS
MIT License
323 stars 31 forks source link

Retain whitespace before color(). Fix for #26. #27

Closed studiosciences closed 8 years ago

studiosciences commented 8 years ago

Replace balance-matched with postcss-value-parser to fix issue whitespace removal issue #26.

studiosciences commented 8 years ago

Merged in the branch that used postcss-value-parser.

Minor Issue: We call .toString() even if no actual color functions were found. This would only occur if there was a "color(" in the value that was not actually a color function, such as "hover-color(".

studiosciences commented 8 years ago

Are you good to merge then? Version number needs a bump.

MoOx commented 8 years ago

@studiosciences can you squash your commit (especially the lasts)? Also why version number needs a bump? According to tests, it's a bugfix.

studiosciences commented 8 years ago

@MoOx I haven't squashed before, but I'll see what I can do.

I'll leave any version changing to you.

studiosciences commented 8 years ago

Squashing complete. It appears as one commit in my branch, but the Pull Request lists six.

Not sure how to fix that or if anything needs to be fixed.

MoOx commented 8 years ago

There is one commit, just refresh the page :D

studiosciences commented 8 years ago

Weird. I saw the squashed commit as an additional commit. Looks right now.

MoOx commented 8 years ago

When you push a commit, github update your open PR, but if you force push, do not remove previous commit until your reload. Pretty buggy UX.

MoOx commented 8 years ago

Will merge and release tomorrow, I have to go :)

studiosciences commented 8 years ago

Anything more I could do to wrap this up?

MoOx commented 8 years ago

Oh sorry, I forgot. Let me handle this this evening.

MoOx commented 8 years ago

Released as 2.0.1, thanks!