search

postcss / postcss-color-function

PostCSS plugin to transform W3C CSS color function to more compatible CSS
MIT License
323 stars 31 forks source link

Tests and fix for upstream css-color-function bug #33

Closed tylergaw closed 6 years ago

tylergaw commented 7 years ago

Ready for merge

Update 2017-10-09: css-color-function@1.3.3 Includes the tint/shade/contrast bug fix. This PR points to that tag now. Can ignore pretty much everything below.

This PR points to ~my fork~ the 1.3.1 tag of css-color-function, so I'm guessing you'd want to wait until the npm package is updated, but wanted to go ahead and get the work in.

Currently, there's a bug in css-color-function when using the tint, shade, and contrast adjusters along with the alpha adjuster. This is due to it's use of the mix function in the Color package it's using.

I have a PR in for the fix there and added more detailed around the problem and solution https://github.com/ianstormtaylor/css-color-function/pull/26

This PR adds tests for the issues and I pushed one failure up so you can see what happens: https://travis-ci.org/tylergaw/postcss-color-function/builds/190518140

For now, I'm just pointing to my fork of css color function to see the code working/tests passing: https://travis-ci.org/tylergaw/postcss-color-function/builds/190518745

~Once PR 26 gets merged I can update the dep here to use the og package.~

Update 2017-07-15 We merged PR/26 over in css-color-function and created a 1.3.1 tag, but have not yet published it to NPM.

This PR now points to Ian's og repo, directly to #1.3.1

MoOx commented 7 years ago

Waiting for a merge upstream.

tylergaw commented 6 years ago

@MoOx Pushed up a change to point to Ian's repo / #1.3.1 tag. We have push access there now. Just pointing to the tag right now until the npm package is updated.

jonathantneal commented 6 years ago

I see css-color-function has been updated to 1.3.1 on npm. Is this safe to merge now, @tylergaw ?

jonathantneal commented 6 years ago

I’m confused. @tylergaw, regardless of the name (color vs color-mod), will these other fixes (breaking changes) make it into this PR?

tylergaw commented 6 years ago

@jonathantneal Yeah, things bounced around a bit. I updated the description here. css-color-function 1.3.3 includes the fixes for the tint/shade adjusters and is backward compatible.

There was a bit of a bump in versioning/breaking changes over there that you can read about in https://github.com/ianstormtaylor/css-color-function/pull/34.

I think this PR is ready to go with 1.3.3.