postcss / postcss-custom-properties

Use Custom Properties in CSS
https://postcss.github.io/postcss-custom-properties
MIT License
597 stars 77 forks source link

Does this plugin strictly process variables that are only on :root? #213

Closed cerinoligutom closed 4 years ago

cerinoligutom commented 4 years ago

I see that this has been asked 4 years ago from #59 . Is this still the case? If yes, maybe it'd be better to put a note in the readme that that's strictly the case.

pascalduez commented 4 years ago

Hi @cerino-ligutom,

yes it's still the case. See https://github.com/postcss/postcss-custom-properties/issues/173#issuecomment-483530357

So basically a dupe of #173

cerinoligutom commented 4 years ago

You'd probably want to put that detail on the readme. Been scratching my head over this for hours as I was expecting it to work just like in scss. Anyways, thanks for confirming quickly.

pascalduez commented 4 years ago

You'd probably want to put that detail on the readme

Agree, that's what I explain in that linked comment.
I'm not a maintainer here.
Maybe you could open a PR to add it back?

cerinoligutom commented 4 years ago

Will try, might save others some time as well.

zachleat commented 4 years ago

:+1: this would be helpful as a README warning

cerinoligutom commented 4 years ago

👍 this would be helpful as a README warning

Need that #214 bumped.