search

postcss / postcss-custom-properties

Use Custom Properties in CSS
https://postcss.github.io/postcss-custom-properties
MIT License
597 stars 77 forks source link

Use the new PostCSS 8.0 API #252

Closed SergeAstapov closed 2 years ago

SergeAstapov commented 2 years ago

This follows https://evilmartians.com/chronicles/postcss-8-plugin-migration and suggestion from @ai in https://github.com/postcss/postcss-nested/issues/124#issuecomment-827611219

Potentially resolves #230.

SergeAstapov commented 2 years ago

Hi @jonathantneal @Semigradsky @ai, sorry to bother. Would you be able to advice if something may need to be tweaked in this PR or if it's good to be merged and released?

Had exact same issue as outlined in #230, was using this branch for few weeks and didn't notice any issues since then.

ai commented 2 years ago

I contacted @Semigradsky by email. If he will not respond in a week, feel free to ping me again, I will merge and release it.

adamjkb commented 2 years ago

@ai 👋 Would it be possible to create a release containing these changes so that #230 will be truly resolved.

Thank you!

ai commented 2 years ago

Hm. I do not have npm access.

jonathantneal commented 2 years ago

It is published, @adamjkb, @SergeAstapov, @ai!

Change log: https://github.com/postcss/postcss-custom-properties/releases/tag/v12.0.0