postcss / postcss-custom-properties

Use Custom Properties in CSS
https://postcss.github.io/postcss-custom-properties
MIT License
596 stars 77 forks source link

Plugin is removing comments and it shouldn't do it. #86

Closed sandrina-p closed 6 years ago

sandrina-p commented 6 years ago

Hey, thanks for your plugin, is amazing!

So, I'm having an issue related to comments that are deleted when those are typed inside the property value.

In my case, I need to use comments in order to use some RTLCSS features.

:root {
    --clrPrimary: red;
}

.title {
      color: var(--clrPrimary)/*rtl:inherit*/;
      font-size:16px/*rtl:14px*/;
}

Expected Output:

.title {
      color: red/*rtl:inherit*/;
      font-size:16px/*rtl:14px*/;
}

Actual Output:

.title {
      color: red;
      font-size:16px/*rtl:14px*/;
}

Would it be possible to fix that?

Thank you 😄

jonathantneal commented 6 years ago

I’ve created a failing test for this here: https://github.com/jonathantneal/postcss-tests/tree/master/postcss-custom-properties-test-00

sandrina-p commented 6 years ago

@jonathantneal When will be released a new patch?

jonathantneal commented 6 years ago

Hi @sandrina-p, this was added in https://github.com/postcss/postcss-custom-properties/commit/59ba7a6ceefb8c6d4eab461f7b1e03e3123cc767, closed by https://github.com/postcss/postcss-custom-properties/pull/89, and released in v6.3.0.

sandrina-p commented 6 years ago

Oh I didn't saw that release. I've cheked here - releases and the last one is v6.2.0, that's why I've asked... 😶 Why isn't v6.3.0 there?

jonathantneal commented 6 years ago

I’d never used releases before. I think it should be fixed now.

And thank you for being infinitely helpful. I am still new to some (or maybe most) of these things.

sandrina-p commented 6 years ago

Oh cool, thanks!

Psoz commented 5 years ago

I think this issue is back again :(

Just like sandrina-p describe it.