search

postcss / postcss-custom-properties

Use Custom Properties in CSS
https://postcss.github.io/postcss-custom-properties
MIT License
596 stars 77 forks source link

Breaking change in 6.3.0 (preserve: true) #93

Closed rexxars closed 6 years ago

rexxars commented 6 years ago

Hi,

6.3.0 switched to preserve: true by default, which breaks a whole lot of things for us. Shouldn't this be a major release signaling a breaking change?

I'd be super happy if a patch/minor could be released that reverted the change, and rather change the default in 7.0.0.

Thoughts?

vikshv commented 6 years ago

+1

jonathantneal commented 6 years ago

I’m okay with this, but I’m curious — shouldn’t preserve also include the fallback values for unsupported browsers? How are you using Custom Properties?

rexxars commented 6 years ago

I don't have a full picture of the problem, but I suspect the problem lies with combining it with postcss-import. Either way, since it can interfere with CSS variables set in other parts of the application, it shouldn't be introduced in a minor version.

jonathantneal commented 6 years ago

It suspect it interferes when Custom Properties are not used to spec. I’ve published 6.3.1 which reverts the option changes in 6.3.0 that will be restored in 7.0.0.

rexxars commented 6 years ago

Thanks a bunch ❤️

jonathantneal commented 6 years ago

Thank you for reporting the issue. I’m keeping this issue open until you’ve confirmed that everything is back to working as expected.

jonathantneal commented 6 years ago

@rexxars, are things back to normal?

rexxars commented 6 years ago

Yup! Thanks again.