search

postcss / postcss-js

PostCSS for React Inline Styles, Free Style and other CSS-in-JS
MIT License
657 stars 25 forks source link

Update camelcase-css, fixing mixed-case properties #30

Closed davidtheclark closed 6 years ago

davidtheclark commented 6 years ago

The latest version of camelcase-css fixes the way mixed-case properties are handled. Now properties are properly camelcased whether the source is uppercase or lowercase. (See https://github.com/stevenvachon/camelcase-css/pull/1)

In addition to updating the dependency, I added a test that fails before the update, illustrating the problem.

ai commented 6 years ago

And why camelcase-css added engine >= 6? ;)

I can’t break Node.js in the patch release. And next major release must be with PostCSS 7 which will be after next week.

ai commented 6 years ago

I think the best solution:

  1. Use postcss-js from GitHub.
  2. After few week I release major version.
davidtheclark commented 6 years ago

👍 sounds good.

davidtheclark commented 6 years ago

@ai If camelcase-css's use reliance on Node 6 is still blocking release, would you be open to a PR that replaces camelcase-css with a function within the codebase (it really doesn't do much)?

ai commented 6 years ago

Node 6 is still blocking release

Not anymore. But I am planning to drop Node.js 4 support with PostCSS 7.

Are we have few weeks for PostCSS 7 release or you want it ASAP (it is not a problem, I will make a release before PostCSS 7).

davidtheclark commented 6 years ago

Ah, no big hurry at all. I was just looking back over some code and realized this was still an outstanding issue for me. I can wait :)