feat: support for postcss 8 plugins

postcss / postcss-load-config

Autoload Config for PostCSS

MIT License

642 stars 72 forks source link

feat: support for postcss 8 plugins #200

Closed m4thieulavoie closed 3 years ago

m4thieulavoie commented 3 years ago

`Notable Changes`

This PR is aiming to support postcss 8 plugins. Not sure if I cover everything in there, or if I should be adding any additional tests

`Commit Message Summary (CHANGELOG)`

Support for postcss 8 plugins

feat: support for postcss 8 plugins

`Type`

[x] Feature

`SemVer`

[X] Feature (:label: Minor)

`Issues`

Fixes #199

`Checklist`

[x] Lint and unit tests pass with my changes
[x] I have added tests that prove my fix is effective/works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes are merged and published in downstream modules

coveralls commented 3 years ago

Coverage remained the same at 98.058% when pulling efc9ebb779cfb4c5438e62e1827c5e3be5ca6a77 on m4thieulavoie:feat/support-postcss-8-plugins into fda5f4a54dcff70c35d5a811a750b4376666cd5f on michael-ciniawsky:master.

ai commented 3 years ago

@michael-ciniawsky can you give me access to the repo and npm package?

m4thieulavoie commented 3 years ago

Do Not Merge; this breaks linting, and I am 99% sure this does not function correctly.

Can you expand on that? Happy to adjust

RyanZim commented 3 years ago

Refs https://github.com/postcss/postcss/issues/1410

Can you expand on that? Happy to adjust

Specifically, I'm not sure what this logic is doing, but I'm pretty sure it's not doing its intended purpose: https://github.com/michael-ciniawsky/postcss-load-config/blob/b03d1950e243f16cd3feb6d9948d35de37cefe37/src/plugins.js#L59-L61 Also, not sure what this plugin.plugins check is even there for. I tested last night, it wasn't broken as I expected, but I'm still not sure this logic is correct; would need to sit down and look closer to be sure.

m4thieulavoie commented 3 years ago

Refs postcss/postcss#1410

Can you expand on that? Happy to adjust

Specifically, I'm not sure what this logic is doing, but I'm pretty sure it's not doing its intended purpose:

https://github.com/michael-ciniawsky/postcss-load-config/blob/b03d1950e243f16cd3feb6d9948d35de37cefe37/src/plugins.js#L59-L61

Also, not sure what this plugin.plugins check is even there for. I tested last night, it wasn't broken as I expected, but I'm still not sure this logic is correct; would need to sit down and look closer to be sure.

Alright, sounds like I'll need to wait for you to come back to me with your conclusion. Please keep me posted, or feel free to scrap that PR with a proper fix if that's easier for you 👍

ai commented 3 years ago

We need a different way to fix https://github.com/michael-ciniawsky/postcss-load-config/pull/202