We previously had a fabricated file name (_) to forcefully resolve a
given directory path to a file path, so createRequire would be happy.
Since we now pass the file path every time, we no longer need this.
In future, if we need to req a directory, we should resolve the path
at the call-site rather than inside req.
Type
[x] Fix
SemVer
[x] Fix (:label: Patch)
Issues
Fixes the problems mentioned in #229.
@ai we really should add some tests for the various ways things can be resolved. could you help with that some time as i dont fully follow what is tested where yet.
basically some tests (if they dont exist already) to ensure we can have various types of paths to plugins (relative, absolute, etc).
We previously had a fabricated file name (
_) to forcefully resolve a given directory path to a file path, socreateRequirewould be happy.Since we now pass the file path every time, we no longer need this.
In future, if we need to
reqa directory, we should resolve the path at the call-site rather than insidereq.TypeSemVerIssuesFixes the problems mentioned in #229.
@ai we really should add some tests for the various ways things can be resolved. could you help with that some time as i dont fully follow what is tested where yet.
basically some tests (if they dont exist already) to ensure we can have various types of paths to plugins (relative, absolute, etc).