search

postcss / postcss-nested

PostCSS plugin to unwrap nested rules like how Sass does it.
MIT License
1.15k stars 66 forks source link

5.0.0+ breaks `ember-css-modules` #140

Closed emattias closed 2 years ago

emattias commented 2 years ago

When using postcss-nested@4.2.3 (latest v4) together with ember-css-modules the classes get generated differently than when using postcss-nested@5.0.6 (latest v5).

See this issue for more info and reproduction repos: https://github.com/salsify/ember-css-modules/issues/253

ai commented 2 years ago

Yeap. postcss-nested@5.0.6 was started using new official PostCSS API (visitor API).

ember-css-modules should update a little to be ready for that because visitor API is a new way to use plugins.

If you know any specific things which can make ember-css-modules integration better, open another issue.

emattias commented 2 years ago

@ai What do you think about what @dfreeman says here: https://github.com/salsify/ember-css-modules/issues/253#issuecomment-975476928 ?

ai commented 2 years ago

Yeap, the Once plugins is a very fast way to convert PostCSS plugin, but it doesn’t help with plugin compatibility.

The idea is to move to true event system with Rule, etc.